Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dia.attributes): prevent error when title is used on element with a text node #2142

Merged
merged 2 commits into from
Apr 24, 2023
Merged

fix(dia.attributes): prevent error when title is used on element with a text node #2142

merged 2 commits into from
Apr 24, 2023

Conversation

kumilingus
Copy link
Contributor

@kumilingus kumilingus commented Apr 19, 2023 •
edited
Loading

Description

Setting title on an element with a text node threw an exception. The PR is supposed to prevent this.

<title @selector="myTitle">existing title<title>
el.attr('myTitle/title', 'new title'); // does not throw an exception now

Note: it is safe to assume that tagName of an SVGElement is always lowercase (SO).

@zbynekstara zbynekstara merged commit 842748a into clientIO:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbynekstara zbynekstara Awaiting requested review from zbynekstara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kumilingus @zbynekstara