Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xml_cmp() compares numeric nodes based on string value #64

Closed
loeliger opened this issue Jan 10, 2019 · 4 comments
Closed

xml_cmp() compares numeric nodes based on string value #64

loeliger opened this issue Jan 10, 2019 · 4 comments

Comments

@loeliger
Copy link

Instead, it should check the spec for the type, convert the string to the correct type and do a numeric comparison for nodes with a numeric type.
@olofhagsand
Copy link
Member

OK.
But there may be cases where the spec is unknown, or ANYXML, where it has to fall back to strcmp/strverscmp.

@gonzopancho
Copy link

True, but if we know we have a number, the compare should be for numeric value.

@olofhagsand
Copy link
Member

Agree

olofhagsand added a commit that referenced this issue Feb 4, 2019
@olofhagsand
xml_cmp() compares numeric nodes based on string value [#64]
1434381
@olofhagsand
Copy link
Member

This should work now

olofhagsand added a commit that referenced this issue Feb 28, 2019
@olofhagsand
Fixed numeric ordering of lists (again) [#64] It was previously just …
fc93051 
…fixed for leaf-lists.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gonzopancho @loeliger @olofhagsand