Pass utf-8 encoding when opening the README #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing an error on my setup where LC_ALL wasn't set to UTF-8.
```
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/private/var/folders/pz/w736zydx5pxdjbn0l0h_28_80000gr/T/pip-install-9c1pe10m/click-spinner/setup.py", line 6, in <module>
readme = f.read()
File "/Users/user/.pyenv/versions/3.5.5/Python.framework/Versions/3.5/lib/python3.5/encodings/ascii.py", line 26, in decode
return codecs.ascii_decode(input, self.errors)[0]
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 373: ordinal not in range(128)
```
Even though this usually happens on wrongly configured environments I think it makes sense to enforce it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing an error on my setup where LC_ALL wasn't set to UTF-8.
Even though this usually happens on wrongly configured environments I think it makes sense to enforce it.