Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #16: Clean out spinner character when done #15

Merged
merged 1 commit into from
Feb 6, 2017

Conversation

andy-maier
Copy link

Please review and merge.

Details:

  • The loop that writes the spinner characters already attempts to have a clean output when the spinner is sopped, by ending with the backslash character. However, there was no flush after the write of the backslash, so that the last spinner character could still be seen. This change adds a flush after the writing of the backslash.

Details:
- The loop that writes the spinner characters already attempts to
  have a clean output when the spinner is sopped, by ending with
  the backslash character. However, there was no flush after the
  write of the backslash, so that the last spinner character
  could still be seen. This change adds a flush after the
  writing of the backslash.

Signed-off-by: Andreas Maier <[email protected]>
@andy-maier andy-maier changed the title Clean out spinner character when done. Fixes #16: Clean out spinner character when done Feb 6, 2017
@yoavram yoavram merged commit f96c31a into click-contrib:master Feb 6, 2017
@yoavram
Copy link
Collaborator

yoavram commented Feb 6, 2017

Thanks!

@kalsky
Copy link

kalsky commented Oct 31, 2017

for me it still happens, tested on Mac and Windows

@yoavram
Copy link
Collaborator

yoavram commented Oct 31, 2017

Could you provide a code example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants