Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: integrate development docker stack with vscode #22

Merged
merged 9 commits into from
Aug 9, 2023

Conversation

Thechi2000
Copy link
Contributor

@Thechi2000 Thechi2000 commented Mar 10, 2023

Some settings that will help development on VS Code

Closes #23

@Thechi2000 Thechi2000 added the devops Related to production deployment and releases label Mar 10, 2023
@Thechi2000 Thechi2000 self-assigned this Mar 10, 2023
@Thechi2000 Thechi2000 changed the title VS Code integration chore: vs code integration Mar 10, 2023
Robb-Fr
Robb-Fr previously approved these changes Mar 10, 2023
Copy link
Member

@Robb-Fr Robb-Fr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great my bro

@codeofmochi codeofmochi added build Improves the build system (devcontainer, dependencies, ...) and removed devops Related to production deployment and releases labels Mar 10, 2023
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your additions! I've left a few suggestions. So I think we are moving towards a monorepo approach where we do bind VSCode to the devcontainer? 👍 I will open an issue for this, it would be great if we use issues systematically so that we leave a written trace for future reference (if possible, I think we should enforce that branches follow the <issue-number>-<description> naming pattern as well).

We may also want to remove the remains of the devcontainer bindings (namely the devcontainer.json files).

Edit: the issue is up at #23

.devcontainer/docker-compose.yaml Outdated Show resolved Hide resolved
.devcontainer/docker-compose.yaml Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
.vscode/tasks.json Outdated Show resolved Hide resolved
.vscode/tasks.json Outdated Show resolved Hide resolved
.vscode/tasks.json Outdated Show resolved Hide resolved
.vscode/tasks.json Outdated Show resolved Hide resolved
.vscode/tasks.json Outdated Show resolved Hide resolved
Thechi2000 and others added 2 commits March 10, 2023 17:12
@codeofmochi codeofmochi changed the title chore: vs code integration chore: integrate development docker stack with vscode May 4, 2023
codeofmochi
codeofmochi previously approved these changes May 4, 2023
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍔 thank you for your work. Should we cleanup the devcontainer files that we will not use anymore?

"presentation": {
"reveal": "always",
"panel": "new"
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if the "start" task is automatically stopped (sigint'd?) when VS code is closed? I think it's best if we ensure that the containers do not continue running in the background. If that is not the case, I'm not sure what we should do since there's nothing equivalent to e.g. folderClose (see microsoft/vscode#65986). Let me know @Thechi2000, thanks! 👍

Copy link
Contributor Author

@Thechi2000 Thechi2000 Aug 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to be possible, but it seems that reopening the folder does not launch more containers; the existing one are reattached into the task. I think we should leave it that way, since there is not much we could do

Should we cleanup the devcontainer

We can remove the unused devcontainer.json files, but the .devcontainer folders are still useful to store the Dockerfile

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thank you. Though I guess since we don't use the -d flag on docker compose up anymore, when the VSCode process dies then the command may stop the stack through SIGINT? No problem anyway, we'll see how well it behaves.

@codeofmochi codeofmochi marked this pull request as ready for review May 25, 2023 10:03
@Thechi2000 Thechi2000 requested a review from codeofmochi August 9, 2023 12:53
Copy link
Contributor

@codeofmochi codeofmochi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 📦 thank you!

@codeofmochi codeofmochi merged commit 687d153 into main Aug 9, 2023
@codeofmochi codeofmochi deleted the vs-code-integration branch August 9, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Improves the build system (devcontainer, dependencies, ...)
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Consider using a local monorepo instead of multiple devcontainers (remote only)
3 participants