Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js): Add nonce to theme provider #4509

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

jescalan
Copy link
Contributor

@jescalan jescalan commented Nov 6, 2024

Description

If using a strict-dynamic CSP with Clerk, you still currently need to add unsafe-inline to the style-src property since we do not thread the nonce into the emotion cache. This change will make it such that you can run the nonce into style-src instead of unsafe-inline and it will work, which means there are no unsafe properties required to be passed for strict dynamic policies when using Clerk in production.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Nov 6, 2024

🦋 Changeset detected

Latest commit: ff94d7f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants