feat(clerk-js,elements,types,localization): Make legal consent stable #4487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 05a105e The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
octoper
force-pushed
the
vaggelis/remove-experimental-for-legal-accepted-at
branch
3 times, most recently
from
d23783e
to
c8ae7f1
Compare
octoper
force-pushed
the
vaggelis/remove-experimental-for-legal-accepted-at
branch
from
c8ae7f1
to
b6493fa
Compare
alexcarpenter
approved these changes
Nov 6, 2024
| @@ -71,7 +68,7 @@ export const LegalCheckbox = ( | |||
| <Flex justify='center'> | |||
| <Field.CheckboxIndicator | |||
| elementDescriptor={descriptors.formFieldCheckboxInput} | |||
| elementId={descriptors.formFieldInput.setId('__experimental_legalAccepted')} | |||
| elementId={descriptors.formFieldInput.setId('legalAccepted')} | |||
| /> | |||
| <FormLabel | |||
There was a problem hiding this comment.
Wonder if the checkbox label should dim when the form is submitting similar to the other input labels. It currently stays at full opacity but the checkbox input dims.
Screen.Recording.2024-11-06.at.3.15.57.PM.mov
There was a problem hiding this comment.
Good catch, I will fix it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR marks legal consent feature as stable
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change