fix(clerk-js): Directory traversal relative URL detection #4483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cb9f3a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
BRKalow
commented
Nov 6, 2024
| (allowedRedirectOrigins: Array<string | RegExp> | undefined) => (_url: string) => { | ||
| if (!allowedRedirectOrigins) { | ||
| return true; | ||
| export const isAllowedRedirect = |
There was a problem hiding this comment.
This function now deals with full URLs, instead of potentially relative URLs as well. This makes our checks more consistent, and removes situations where we treat a relative URL as okay, make it absolute, and then it ends up being problematic.
BRKalow
commented
Nov 6, 2024
| @@ -84,18 +84,38 @@ describe('isValidUrl(url,base)', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('isRelativeUrl(url,base)', () => { | |||
| describe('isProblematicUrl(url)', () => { | |||
There was a problem hiding this comment.
Could potentially do with more test cases here, but with the shift to checking against full URLs we get more guarantees from the existing origin check.
nikosdouvlis
force-pushed
the
brk.fix/redirect-validation
branch
from
9876c25
to
cb9f3a1
Compare
nikosdouvlis
approved these changes
Nov 6, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change