Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): Ensure turbo cache is used properly for e2e tests #4435

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

BRKalow
Copy link
Member

@BRKalow BRKalow commented Oct 30, 2024

Description

Currently, args pass to turbo tasks are (understandably) included in the hash, and ultimately the cache key. As it relates to e2e tests, we pass a --project argument to the turbo task run, along with --only. What this means is turbo doesn't consider the task's dependencies when determining if the task has been cached or not.

This is problematic for us, as only the integration/ directory is included in the inputs. I've changed the command to not pass the --project arg, as it only has the chrome value today, and is otherwise unused. I also removed the --only flag. This should allow turbo to only re-run the integration tests if dependent packages have changed.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Latest commit: 117f2d9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -25,8 +25,7 @@
"VITE_CLERK_*",
"EXPO_PUBLIC_CLERK_*",
"REACT_APP_CLERK_*",
"NEXT_PHASE",
"E2E_NEXTJS_VERSION"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would bust the build cache across tests against diff next versions, which we don't want.

@BRKalow BRKalow merged commit e227f6b into main Oct 31, 2024
23 checks passed
@BRKalow BRKalow deleted the brk.fix/e2e-tests-caching branch October 31, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants