fix(repo): Ensure turbo cache is used properly for e2e tests #4435
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, args pass to turbo tasks are (understandably) included in the hash, and ultimately the cache key. As it relates to e2e tests, we pass a
--project
argument to the turbo task run, along with--only
. What this means is turbo doesn't consider the task's dependencies when determining if the task has been cached or not.This is problematic for us, as only the
integration/
directory is included in the inputs. I've changed the command to not pass the--project
arg, as it only has thechrome
value today, and is otherwise unused. I also removed the--only
flag. This should allow turbo to only re-run the integration tests if dependent packages have changed.Checklist
npm test
runs as expected.npm run build
runs as expected.Type of change