Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Remove blank descriptors #4371

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Conversation

dstaley
Copy link
Member

@dstaley dstaley commented Oct 18, 2024

Description

This PR removes the need to declare blank descriptors to satisfy TypeScript. It also defines the available descriptors in terms of OAUTH_PROVIDERS and WEB3_PROVIDERS instead of hardcoding those descriptors.

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Oct 18, 2024

🦋 Changeset detected

Latest commit: 44a529f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@alexcarpenter alexcarpenter merged commit 1997eac into main Oct 22, 2024
21 checks passed
@alexcarpenter alexcarpenter deleted the ds.fix/descriptor-cleanup branch October 22, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants