fix(clerk-js): Handle gracefully yet unknown to our components Web3 providers #4263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roviders If FAPI returns a Web3 provider that is not yet known to our types and components, then we fail to render them. We fix that by filtering them out, as we do for OAuth
chanioxaris
requested review from
nikosdouvlis,
octoper,
nikospapcom,
anagstef,
panteliselef and
EmmanouelaPothitou
🦋 Changeset detectedLatest commit: 7739840 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
panteliselef
approved these changes
Oct 1, 2024
nikospapcom
approved these changes
Oct 1, 2024
anagstef
approved these changes
Oct 1, 2024
chanioxaris
deleted the
haris/user-794-gracefully-handle-unknown-web3-provider-for-clerkjs-v4
branch
chanioxaris
added a commit
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If FAPI returns a Web3 provider that is not yet known to our types and components, then we fail to render them. We fix that by filtering them out, as we do for OAuth
Before
After
Checklist
npm testruns as expected.npm run buildruns as expected.Type of change