Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clerk-js,ui,types): Hide sign up url from <SignIn /> component mode is restricted #4206

Conversation

nikospapcom
Copy link
Member

@nikospapcom nikospapcom commented Sep 23, 2024

Description

Hide sign up url from component when the Invite-Only mode is turned on.

In a following pr we're going to introduce e2e tests

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

366093900-1003a246-0a1f-4e19-a4ac-4193f5bb078f
366093974-6f5afc65-19f1-4406-a808-58b80b45c5dd

Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: 3805b93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 18 packages
Name Type
@clerk/clerk-js Minor
@clerk/types Minor
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch
@clerk/astro Patch
@clerk/backend Patch
@clerk/elements Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/localizations Patch
@clerk/nextjs Patch
@clerk/clerk-react Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/shared Patch
@clerk/tanstack-start Patch
@clerk/testing Patch
@clerk/themes Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikospapcom nikospapcom self-assigned this Sep 23, 2024
@nikospapcom nikospapcom force-pushed the nikospap/user-690-use-the-environment-for-hiding-the-prompt-to-sign-up-from branch 2 times, most recently from 086a8c8 to d785440 Compare September 23, 2024 14:23
@nikospapcom nikospapcom marked this pull request as ready for review September 23, 2024 14:57
@nikospapcom nikospapcom force-pushed the nikospap/user-690-use-the-environment-for-hiding-the-prompt-to-sign-up-from branch 3 times, most recently from eb18bd1 to 0db0e51 Compare September 24, 2024 10:10
@nikospapcom nikospapcom force-pushed the nikospap/user-690-use-the-environment-for-hiding-the-prompt-to-sign-up-from branch from 0db0e51 to 3805b93 Compare September 24, 2024 12:19
@nikospapcom nikospapcom merged commit c906385 into main Sep 25, 2024
20 checks passed
@nikospapcom nikospapcom deleted the nikospap/user-690-use-the-environment-for-hiding-the-prompt-to-sign-up-from branch September 25, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants