Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): Replace session-token-outdated error with more specific errors #4205

Merged

Conversation

anagstef
Copy link
Member

@anagstef anagstef commented Sep 23, 2024

Description

This PR replaces the 'session-token-outdated' auth error reason with the following 4 more specific ones:

  1. 'session-token-expired': Session token has expired.
  2. 'session-token-iat-before-client-uat': Session token was issued before the timestamp depicted in __client_uat
  3. 'session-token-not-active-yet': Current time was before session token's nbf claim (possible clock skew)
  4. 'session-token-iat-in-the-future': Session token was issued in the future (possible clock skew)

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Sep 23, 2024

🦋 Changeset detected

Latest commit: 76f13fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@clerk/backend Patch
@clerk/astro Patch
@clerk/express Patch
@clerk/fastify Patch
@clerk/nextjs Patch
@clerk/remix Patch
@clerk/clerk-sdk-node Patch
@clerk/tanstack-start Patch
@clerk/testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@anagstef anagstef self-assigned this Sep 23, 2024
@anagstef
Copy link
Member Author

!snapshot

@anagstef anagstef marked this pull request as ready for review September 23, 2024 11:29
@clerk-cookie
Copy link
Collaborator

Hey @anagstef - the snapshot version command generated the following package versions:

Package Version
@clerk/astro 1.3.7-snapshot.v8eae310
@clerk/backend 1.13.3-snapshot.v8eae310
@clerk/chrome-extension 1.3.9-snapshot.v8eae310
@clerk/clerk-js 5.22.4-snapshot.v8eae310
@clerk/elements 0.15.5-snapshot.v8eae310
@clerk/clerk-expo 2.2.15-snapshot.v8eae310
@clerk/express 0.1.4-snapshot.v8eae310
@clerk/fastify 1.0.46-snapshot.v8eae310
@clerk/localizations 3.0.5-snapshot.v8eae310
@clerk/nextjs 5.6.1-snapshot.v8eae310
@clerk/clerk-react 5.9.2-snapshot.v8eae310
@clerk/remix 4.2.30-snapshot.v8eae310
@clerk/clerk-sdk-node 5.0.43-snapshot.v8eae310
@clerk/shared 2.8.2-snapshot.v8eae310
@clerk/tanstack-start 0.4.6-snapshot.v8eae310
@clerk/testing 1.3.4-snapshot.v8eae310
@clerk/themes 2.1.31-snapshot.v8eae310
@clerk/types 4.21.1-snapshot.v8eae310

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/astro

npm i @clerk/[email protected] --save-exact

@clerk/backend

npm i @clerk/[email protected] --save-exact

@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/elements

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

@clerk/express

npm i @clerk/[email protected] --save-exact

@clerk/fastify

npm i @clerk/[email protected] --save-exact

@clerk/localizations

npm i @clerk/[email protected] --save-exact

@clerk/nextjs

npm i @clerk/[email protected] --save-exact

@clerk/clerk-react

npm i @clerk/[email protected] --save-exact

@clerk/remix

npm i @clerk/[email protected] --save-exact

@clerk/clerk-sdk-node

npm i @clerk/[email protected] --save-exact

@clerk/shared

npm i @clerk/[email protected] --save-exact

@clerk/tanstack-start

npm i @clerk/[email protected] --save-exact

@clerk/testing

npm i @clerk/[email protected] --save-exact

@clerk/themes

npm i @clerk/[email protected] --save-exact

@clerk/types

npm i @clerk/[email protected] --save-exact

@nikosdouvlis nikosdouvlis merged commit c59636a into main Sep 23, 2024
14 of 20 checks passed
@nikosdouvlis nikosdouvlis deleted the stefanos/split-session-token-outdated-error-into-more branch September 23, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants