Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clerk-js): UP/OP footer padding on small screens #4191

Conversation

octoper
Copy link
Member

@octoper octoper commented Sep 19, 2024

Description

This PR fixes wrong padding on the footer of UP and OP components when development notice was enabled and it was viewed in small screens

Before

CleanShot 2024-09-19 at 13 37 05@2x

After

CleanShot 2024-09-19 at 13 36 34@2x

Checklist

  • npm test runs as expected.
  • npm run build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: 50327c0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@octoper
Copy link
Member Author

octoper commented Sep 19, 2024

!preview

@clerk-cookie
Copy link
Collaborator

clerk-cookie commented Sep 19, 2024

Hey @octoper, your preview is available.

Status Preview Updated (UTC)
🍪 Deployed Visit preview Sep 19, 2024 10:42 AM

@nikospapcom
Copy link
Member

!snapshot

@clerk-cookie
Copy link
Collaborator

Hey @nikospapcom - the snapshot version command generated the following package versions:

Package Version
@clerk/chrome-extension 1.3.9-snapshot.v6f97388
@clerk/clerk-js 5.22.4-snapshot.v6f97388
@clerk/clerk-expo 2.2.15-snapshot.v6f97388

Tip: Use the snippet copy button below to quickly install the required packages.
@clerk/chrome-extension

npm i @clerk/[email protected] --save-exact

@clerk/clerk-js

npm i @clerk/[email protected] --save-exact

@clerk/clerk-expo

npm i @clerk/[email protected] --save-exact

Copy link
Member

@nikospapcom nikospapcom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@octoper octoper force-pushed the vaggelis/sdki-668-wrong-padding-for-dev-notice-on-mobile-for-upop branch from 6f97388 to 50327c0 Compare September 19, 2024 11:51
@octoper octoper enabled auto-merge (squash) September 19, 2024 11:51
@octoper octoper merged commit ef824dc into main Sep 19, 2024
20 checks passed
@octoper octoper deleted the vaggelis/sdki-668-wrong-padding-for-dev-notice-on-mobile-for-upop branch September 19, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants