fix: Incompatible __client_uat & __session should show interstitial #51
Conversation
lib/clerk/rack_middleware_v2.rb
Outdated
| if production? && client_uat.nil? | ||
| return signed_out(env) | ||
| # Show interstitial when there is no client_uat or cookie token | ||
| if (client_uat == "0" || client_uat.nil?) && cookie_token.to_s.empty? |
There was a problem hiding this comment.
❓ That's the signed-out client_uat value, right? Just noting in case we need to update the comment accordingly.
There was a problem hiding this comment.
Yes the client_uat == "0" refers to the signed-out state. I updated the code and the comment since it was incorrect to use that. The case here is to render interstitial when there is no client_uat and cookie token information.
|
|
||
| # Show interstitial when there is client_uat is incompatible with cookie token | ||
| has_cookie_token_without_client = (client_uat == "0" || client_uat.nil?) && cookie_token | ||
| has_client_without_cookie_token = (client_uat.to_s != "0" || client_uat.to_s != "") && cookie_token.to_s.empty? |
There was a problem hiding this comment.
❓ Where does the client_uat.to_s != "" case correspond here to?
There was a problem hiding this comment.
it corresponds to the case where the client_uat is missing or the value is somehow removed. We could use the client_uat.nil? if that makes it more readable but i think this check is safer because it also applies to cases where the client_uat exists without value (due to some edge-case or extension or something).
lib/clerk/rack_middleware_v2.rb
Outdated
| return unknown(interstitial: true) if has_cookie_token_without_client || has_client_without_cookie_token | ||
|
|
||
| # Show interstitial when there is client_uat is incompatible with cookie token | ||
| if (client_uat == "0" || client_uat.nil?) && cookie_token.to_s.empty? |
There was a problem hiding this comment.
🔧 Same check as in line 174 could be assigned to a variable? Just for aggregating the cases at a single location maybe?
There was a problem hiding this comment.
i have updated that :)
dimkl
force-pushed
the
hotfix/interstitial-prod-instance
branch
from
8dfcca3
to
f4954be
Compare
dimkl
force-pushed
the
hotfix/interstitial-prod-instance
branch
from
f4954be
to
dcad415
Compare
dimkl
force-pushed
the
hotfix/interstitial-prod-instance
branch
from
dcad415
to
6d8dc34
Compare
Handle 2 interstitial cases:
client_uatandcookie tokeninfo (both for dev and production apps)client_uathas a value that does not match with thecookie tokenvalue