Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handshake fixes #46

Merged
merged 3 commits into from
Feb 23, 2024
Merged

Handshake fixes #46

merged 3 commits into from
Feb 23, 2024

Conversation

dimkl
Copy link
Contributor

@dimkl dimkl commented Feb 22, 2024

Changes:

  • Make CLERK_PUBLISHABLE_KEY env required and update README
  • Add comments and refactor code to improve readability in handshake resolution
  • Apply minor code styling refactorings

related: #45

@dimkl dimkl requested review from agis and gkats February 22, 2024 18:30
@dimkl dimkl self-assigned this Feb 22, 2024
gkats
gkats approved these changes Feb 23, 2024
View reviewed changes
Copy link
Member

@gkats gkats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

lib/clerk.rb Show resolved Hide resolved
@dimkl dimkl merged commit 37f752a into main Feb 23, 2024
2 checks passed
@dimkl dimkl deleted the handshake-fixes branch February 23, 2024 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkats gkats gkats approved these changes

@agis agis Awaiting requested review from agis

Assignees

@dimkl dimkl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dimkl @gkats