fix: Make JWKS cache shared between SDK instances #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agis
changed the title
agis
force-pushed
the
AUTH-76-jwks-threadsafe-cache
branch
from
ca96fbb
to
a8d5756
Compare
gkats
approved these changes
Dec 22, 2022
After 1123911 the JWKs cache wasn't working as expected, since the middleware constructed a new SDK instance on each request. So each request was effectively bypassing the cache, since the cache was essentially an instance variable which was re-initialized anew every time. With this change, the JWKs cache is made thread-safe and shared between all instances of the SDK. Fixes AUTH-76
agis
force-pushed
the
AUTH-76-jwks-threadsafe-cache
branch
from
a8d5756
to
a875122
Compare
SokratisVidros
approved these changes
Dec 22, 2022
gkats
approved these changes
Dec 22, 2022
AUTH-76 Ruby SDK middleware bypasses the JWKs cache
After this change, the auth middleware essentially does not leverage the JWKS cache, since a new SDK instance is constructed per request (and the cache is essentially an instance variable). We have to find a way to leverage some form of JWKs caching while also keeping our middleware thread-safe. The above issue was discovered after we saw excessive amounts of requests to the BAPI JWKs endpoint from Finary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After 1123911 the JWKs cache wasn't working as expected, since the
middleware constructed a new SDK instance on each request. So each
request was effectively bypassing the cache, since the cache was
essentially an instance variable which was re-initialized anew every
time.
With this change, the JWKs cache is made thread-safe and shared between
all instances of the SDK.
Fixes AUTH-76