Handle invalid json in authorization header #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if an app uses HTTP basic auth anywhere in its application (e.g. using Sidwkiq web interface with HTTP basic auth protection), the middleware errors out due to the HTTP_AUTHORIZATION header not being valid JSON. Added error handling in this case to prevent the middleware blocking requests
if an app uses HTTP basic auth anywhere in its application (e.g. using Sidwkiq web interface with HTTP basic auth protection), the middleware errors out due to the HTTP_AUTHORIZATION header not being valid JSON. Added error handling in this case to prevent the middleware blocking requests
|
This looks good, thanks for tackling it @intothefire! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an app uses HTTP basic auth anywhere in its application (e.g. using Sidekiq web interface with HTTP basic auth protection), the middleware errors out due to the HTTP_AUTHORIZATION header not being valid JSON. This prevents access to these routes, in my case preventing access to the Sidekiq Web UI which we use a great deal.
Added simple error handling, in this case, to prevent the middleware from blocking requests unnecessarily.