Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Unauthorized sign-in #1668

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

feat: Unauthorized sign-in #1668

wants to merge 23 commits into from

Conversation

gkats
Copy link
Member

@gkats gkats commented Oct 30, 2024

Explanation:

We're launching a new feature that detects sign-ins from unrecognized devices and sends a notification to the users.

This PR:

  • Added a section under Security for unauthorized sign-ins.
  • Added the unauthorized sign-in page in the Account Portal docs.

Added a section under Security for unauthorized sign-ins.
Added the unauthorized sign-in page in the Account Portal docs.
@gkats gkats requested a review from a team as a code owner October 30, 2024 13:47
Copy link

Hey, here’s your docs preview: https://clerk.com/docs/pr/1668

docs/security/unauthorized-sign-in.mdx Outdated Show resolved Hide resolved
docs/security/unauthorized-sign-in.mdx Outdated Show resolved Hide resolved
Comment on lines 16 to 20
1. Navigate to the [Clerk Dashboard](https://dashboard.clerk.com/last-active).
1. In the secondary navigation header, select **Configure**.
1. From the navigation sidebar, select **Emails** under the **Customization** menu group.
1. Locate the **New client sign in** email template and click on the toggle next to it in order to disable the feature.
1. You can customize the email content, similar to how you can customize the rest of the email templates. See [Email and SMS templates](/docs/authentication/configuration/email-sms-templates) for more information.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the New client sign in email template. Has it been renamed to Magic link - Sign in?

image
Suggested change
1. Navigate to the [Clerk Dashboard](https://dashboard.clerk.com/last-active).
1. In the secondary navigation header, select **Configure**.
1. From the navigation sidebar, select **Emails** under the **Customization** menu group.
1. Locate the **New client sign in** email template and click on the toggle next to it in order to disable the feature.
1. You can customize the email content, similar to how you can customize the rest of the email templates. See [Email and SMS templates](/docs/authentication/configuration/email-sms-templates) for more information.
1. In the Clerk Dashboard, navigate to the [**Emails**](https://dashboard.clerk.com/last-active?path=customization/email) page.
1. Select the **Magic link - Sign in** option. You'll be redirected to the template settings page.
1. Toggle **Delivered by Clerk** to enable the feature.
1. Select **Apply changes**.
1. To customize the email content, see the [Email and SMS templates](/docs/authentication/configuration/email-sms-templates) guide.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@victoriaxyz The feature is not yet live. The release is a bit blocked. I thought I would start working on the docs while I was waiting to be unblocked.

The New client sign in email template is not visible in production yet. It's present on our staging environment, and after we release the feature in production we can merge this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! You can replace the title with New client sign in once the feature is released.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's another change that's yet to be released and that is the part about enabling/disabling the email from the list.

In the future, dashboard users will be able to toggle certain emails on or off. This is not yet live. I've updated the instructions with your suggestions for now, and I'll make sure I change them once the new functionality becomes available.

Thanks for taking a look and sorry for any confusion.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, let me know when you need a new review.

docs/security/unauthorized-sign-in.mdx Outdated Show resolved Hide resolved
docs/security/unauthorized-sign-in.mdx Outdated Show resolved Hide resolved
docs/security/unauthorized-sign-in.mdx Outdated Show resolved Hide resolved
docs/security/unauthorized-sign-in.mdx Outdated Show resolved Hide resolved
docs/security/unauthorized-sign-in.mdx Outdated Show resolved Hide resolved
docs/security/unauthorized-sign-in.mdx Outdated Show resolved Hide resolved
Until we get the new Emails redesign page in the dashboard, we'll keep
the configuration section to the minimum required.
docs/customization/account-portal/overview.mdx Outdated Show resolved Hide resolved
docs/security/unauthorized-sign-in.mdx Outdated Show resolved Hide resolved
docs/security/unauthorized-sign-in.mdx Outdated Show resolved Hide resolved

1. In the Clerk Dashboard, navigate to the [**Emails**](https://dashboard.clerk.com/last-active?path=customization/email) page.
1. Select the **New Client Sign In** option. You'll be redirected to the template settings page.
1. Toggle **Delivered by Clerk** to enable the feature.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Toggle **Delivered by Clerk** to enable the feature.
1. Toggle **Delivered by Clerk** to enable or disable the feature.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change soon. The correct way to enable/disable the feature needs an Emails page redesign which should be landing soonish.

I won't merge this PR before the new redesign is live and I update this step.

docs/security/unauthorized-sign-in.mdx Outdated Show resolved Hide resolved
docs/security/unauthorized-sign-in.mdx Outdated Show resolved Hide resolved
docs/security/unauthorized-sign-in.mdx Outdated Show resolved Hide resolved
docs/security/unauthorized-sign-in.mdx Outdated Show resolved Hide resolved
docs/security/unauthorized-sign-in.mdx Outdated Show resolved Hide resolved
@alexisintech alexisintech marked this pull request as draft November 4, 2024 17:37
@alexisintech
Copy link
Member

converting to draft until the feature is ready for release, and then we can revisit this pr and make the necessary updates!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants