New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to work on Lua52 #46

Merged

soumith merged 1 commit into clementfarabet:master from nagadomi:fix_ffi_error_on_lua52

Mar 2, 2017

Contributor

nagadomi commented Mar 2, 2017

This PR fixes a following error on Lua 5.2 (When torch is installed with TORCH_LUA_VERSION=LUA52 ./install.sh).

/home/nagadomi/torch/install/bin/lua: unable to convert argument 1 from cdata<double> to cdata<intptr_t>
stack traceback:
	[C]: in function 'tonumber'
	...omi/torch/install/share/lua/5.2/graphicsmagick/Image.lua:631: in function 'colorspace'

I tested it works on LuaJIT 2.1 and Lua 5.2.


          Fix to work on Lua52

ff30c1f

nagadomi mentioned this pull request

Failed to Load Image nagadomi/waifu2x#174

Closed

soumith merged commit 203df44 into clementfarabet:master

Collaborator

soumith commented Mar 2, 2017

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet