Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add now-required env vars to docs and minimal.env.json #1083

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Add now-required env vars to docs and minimal.env.json #1083

merged 1 commit into from
Apr 4, 2024

Conversation

lumaxis
Copy link
Contributor

@lumaxis lumaxis commented Apr 3, 2024

Updates the minimal.env.json file and the rampup.md files to mention the now-required WEBHOOK_GITHUB_SECRET and WEBHOOK_CRAWLER_SECRET secrets. This is a follow-up to changes in #1058

@lumaxis lumaxis requested review from elrayle and qtomlinson April 3, 2024 15:40
@lumaxis
Copy link
Contributor Author

lumaxis commented Apr 3, 2024

@yashkohli88 FYI 🙂 Thanks for pointing this out!

@lumaxis lumaxis mentioned this pull request Apr 3, 2024
Merged
qtomlinson
qtomlinson approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@qtomlinson qtomlinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@lumaxis lumaxis merged commit cfcd81e into master Apr 4, 2024
3 checks passed
@lumaxis lumaxis deleted the update-required-env-docs branch April 4, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qtomlinson qtomlinson qtomlinson approved these changes

@elrayle elrayle Awaiting requested review from elrayle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lumaxis @qtomlinson