Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate parts (or most) of Chromium OS's gen_autosuspend_rules.py script #9

Open
thac0 opened this issue Oct 18, 2019 · 2 comments
Open
Labels
enhancement New feature or request

Comments

@thac0
Copy link
Contributor

thac0 commented Oct 18, 2019

Summary says it all. See the following:

Investigate how much we can (or ought) to reuse/leverage, and integrate it into clr-power-tweaks.

@thac0 thac0 added the enhancement New feature or request label Oct 18, 2019
@thac0 thac0 self-assigned this Oct 18, 2019
@thac0
Copy link
Contributor Author

thac0 commented Oct 18, 2019

Going to leverage the PCI_IDS and USB_IDS data sets directly and ignore the udev construction stuff altogether. A tip of the hat to the CrOS developers for writing a nice script that we can leverage. 😁

The CrOS script is written in Python. Currently, clr-power-tweaks only generates C-code (with a perl script) for sysfs/procfs nodes specified in clr-power-tweaks.conf. To effectively leverage the CrOS whitelist script, I deem it necessary to generate headers for inclusion by pci.c and usb.c.

With my pedant hat on, it seems overkill to require perl and python at build-time. I am seriously considering re-implementing generate-tweaks.pl in python so all generation is done in one scripting language (python).

thac0 added a commit that referenced this issue Oct 22, 2019
Readying for #9 enhancement, Part 1
@ahkok
Copy link
Contributor

ahkok commented Feb 7, 2020

#14 completely removes the need for it. There is really no use for a compile time parsed static list - I just made it a static list in C.

@ahkok ahkok unassigned thac0 Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants