Enable sriov-network-device-plugin vfio mode #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a cni to mirror MAC address of VF on a veth pair with results from ipam applied to enable DPDK apps to configure themselves when operating sriov-network-device-plugin in vfio mode Updated helper sriov.sh to allow for binding VFs to vfio-pci on boot Signed-off-by: Saikrishna Edupuganti <[email protected]>
krsna1729
commented
Jan 26, 2019
| @@ -16,10 +16,18 @@ RUN git clone -q https://github.com/intel/sriov-network-device-plugin.git /go/sr | |||
| WORKDIR /go/src/github.com/intel/sriov-network-device-plugin | |||
| RUN make | |||
|
|
|||
| # Build vfioveth plugin | |||
| FROM busybox as vfioveth | |||
| RUN wget -O /bin/vfioveth https://raw.githubusercontent.com/clearlinux/cloud-native-setup/master/clr-k8s-examples/9-multi-network/cni/vfioveth && \ | |||
There was a problem hiding this comment.
need to change this one to COPY since its local
krsna1729
commented
Jan 26, 2019
| @@ -1,3 +1,6 @@ | |||
| # If you set "deviceType": "vfio", | |||
There was a problem hiding this comment.
Have both examples maybe?
krsna1729
commented
Jan 26, 2019
| @@ -1,3 +1,6 @@ | |||
| # If you set "deviceType": "vfio", | |||
| # - uncomment line `bind_vfs_vfio $pf` in systemd/sriov.sh | |||
There was a problem hiding this comment.
accept an option --vfio in the script that says whether to bind to vfio-pci or leave it with kernel
krsna1729
commented
Jan 26, 2019
| @@ -1,3 +1,6 @@ | |||
| # If you set "deviceType": "vfio", | |||
| # - uncomment line `bind_vfs_vfio $pf` in systemd/sriov.sh | |||
| # - set "type": "vfioveth" in test/sriov/0-sriov-net.yaml | |||
There was a problem hiding this comment.
add extra network to show use of vfioveth
Addressing comments - 1a. added flag to `sriov.sh` to indicate bind to vfio-pci 1b. systemd unit sets up two pools 1 per mode 2a. updated `sriov-conf.yaml` to use the two pools 3a. included network examples for both resource pools 3b. included pod examples for both resource pools Signed-off-by: Saikrishna Edupuganti <[email protected]>
krsna1729
added
do-not-merge
Signed-off-by: Saikrishna Edupuganti <[email protected]>
krsna1729
force-pushed
the
topic/sriov-improvements
branch
from
592c0d4 to
0a00800
Compare
mcastelino
approved these changes
Feb 6, 2019
There was a problem hiding this comment.
LGTM.
We need to see how we can make it a little more generic.
Say an central IPAM and some sort of simple inter node connectivity.
One use case is to create a rook storage network
/cc @ganeshmaharaj rook has multiple network support right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a CNI to mirror MAC address of VF on a veth pair, along with results
from ipam applied, to enable DPDK apps to configure themselves when
operating sriov-network-device-plugin in vfio mode. k8snetworkplumbingwg/sriov-cni#37
Updated helper sriov.sh to allow for binding VFs to vfio-pci on boot
Signed-off-by: Saikrishna Edupuganti [email protected]