Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaling factor for timeline, custom render popup function, prop documentation #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

brianweiner
Copy link
Contributor

Cool library! We needed something that displayed in a gantt-like manner without any actual management behaviors.

I took a shot at documenting the props. I was going to add another column for defaults / examples, but thought maybe you'd have some comments first.

We needed custom messaging for the popup, I added a renderPopup prop for GanttRow so we could pass a curried function in that let us combine row-specific details into the rendered message. We thought maybe this would be useful for other users as well.

Also had some issues with the calculated # of ticks -- I ended up just using a simple scaling factor to increase the # that was calculated.

You won't offend me if you reject :)

@clayrisser
Copy link
Owner

Could you separate the documentation into a separate pull request?

@brianweiner brianweiner force-pushed the add-scaling-factor-for-timeline branch from 19564fe to 3aa2455 Compare June 12, 2018 17:21
@brianweiner
Copy link
Contributor Author

Sure np #14

@clayrisser
Copy link
Owner

It might be a week before I finally get to review this

@clayrisser
Copy link
Owner

Thanks for the prop documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants