Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --pg-env option for passing environment to the PostgreSQL container #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nicfit
Copy link
Contributor

@nicfit nicfit commented Feb 19, 2020

Recent postgres images require POSTGRES_HOST_AUTH_METHOD=trust
to allow behavior matching prior versions.

…ntainer.

Recent postgres images require `POSTGRES_HOST_AUTH_METHOD=trust`
to allow behavior matching prior versions.
@nicfit nicfit requested a review from clayman083 February 21, 2020 21:42
Copy link
Owner

@clayman083 clayman083 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok, but you should repair tests first.

@nicfit
Copy link
Contributor Author

nicfit commented Feb 26, 2020

In fixing the tests it occurred to me that although --pg-env is a nice option, what I am using it for should actually be set/used by default in pytest-postgres. i.e. the tests will always fail using the latest postgresql images without POSTGRES_HOST_AUTH_METHOD=trust.

@nicfit
Copy link
Contributor Author

nicfit commented Feb 26, 2020

@clayman74 , for example eb75498

@coveralls
Copy link

Coverage Status

Coverage decreased (-1.2%) to 85.556% when pulling eb75498 on nicfit:master into 91fc4f5 on clayman74:master.

@nicfit nicfit changed the title Added --pg-env option for passingn environment to the PostgreSQL container Added --pg-env option for passing environment to the PostgreSQL container Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants