Ignore OS as an input to GenerateProtoTask
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will remove the OS from the input properties of the GenerateProtoTask when `protoc` is defined as a resolvable artifact. The expectation is that same versions of protoc will produce same outputs regardless of the OS on which it was run. This is done by removing the "protoc" key from the `alternativePaths` property when present and not a SNAPSHOT and adding a protocArtifactGav property as an input that only considers the group, artifact ID, and version of the resolvable `protoc`. See google#457.
runningcode
reviewed
Apr 29, 2022
| return objectFactory.fileCollection().from(getLocatorToAlternativePathsMapping().get().values()) | ||
| objectFactory.fileCollection().from(locatorToAlternativePathsMapping.map { | ||
| if (protocArtifactGav.map { !it.endsWith("-SNAPSHOT") }.getOrElse(false)) { | ||
| it.findAll { it.key != protocLocator.get().name } |
There was a problem hiding this comment.
Could you add a comment explaining what the logic is and why it is that way? I think this would help future readers or when trying to debug things here.
It would also be good here to name parameters since I think we have nested it and it becomes hard to follow which one is which.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will remove the OS from the input properties of the
GenerateProtoTask when
protocis defined as a resolvable artifact. Theexpectation is that same versions of protoc will produce same outputs
regardless of the OS on which it was run.
This is done by removing the "protoc" key from the
alternativePathsproperty when present and not a SNAPSHOT and adding a protocArtifactGav
property as an input that only considers the group, artifact ID, and
version of the resolvable
protoc.See google#457.