Skip to content

Commit

Permalink
apacheGH-39136: [C++] Remove needless system Protobuf dependency with…
Browse files Browse the repository at this point in the history
… -DARROW_HDFS=ON (apache#39137)

### Rationale for this change

Our HDFS related codes don't depend on Protobuf because we process HDFS via external `libhdfs.so` and it's `dlopen()`-ed.

### What changes are included in this PR?

Remove a needless CMake configuration. 

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* Closes: apache#39136

Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
  • Loading branch information
kou authored and clayburn committed Jan 23, 2024
1 parent 46d77fa commit 73d6c9b
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions cpp/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -873,9 +873,6 @@ add_dependencies(arrow_test_dependencies toolchain-tests)
if(ARROW_STATIC_LINK_LIBS)
add_dependencies(arrow_dependencies ${ARROW_STATIC_LINK_LIBS})
if(ARROW_HDFS OR ARROW_ORC)
if(Protobuf_SOURCE STREQUAL "SYSTEM")
list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS ${ARROW_PROTOBUF_LIBPROTOBUF})
endif()
if(NOT MSVC_TOOLCHAIN)
list(APPEND ARROW_STATIC_LINK_LIBS ${CMAKE_DL_LIBS})
list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS ${CMAKE_DL_LIBS})
Expand Down

0 comments on commit 73d6c9b

Please sign in to comment.