New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix import by making support more explicit #92

Merged

nelsonpecora merged 2 commits into master from fix-import

Sep 4, 2018

Contributor

nelsonpecora commented Sep 4, 2018 •

edited

Loading

pulls out import handling logic to make it more clear
we handle importing from stream of strings, string, object, and Buffer (the last one was causing an issue with v3.4.x)

nelsonpecora added 2 commits

September 4, 2018 12:06


          fix import by making support more explicit

d3bb085


          pulled out complex function

coveralls commented Sep 4, 2018

Coverage remained the same at 100.0% when pulling 5359855 on fix-import into 4ae8b2e on master.

cruzanmo approved these changes

View reviewed changes

reubenson approved these changes

View reviewed changes

nelsonpecora merged commit 0b8fa3f into master

nelsonpecora deleted the fix-import branch

September 4, 2018 16:15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet