fix: fetch undici agent support, node 16+ #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealcantara22
changed the title
ealcantara22
changed the title
james-owen
approved these changes
Aug 30, 2024
| const h = require('highland'), | ||
| _ = require('lodash'), | ||
| nodeUrl = require('url'), | ||
| https = require('https'), | ||
| { Agent } = require('undici'), |
There was a problem hiding this comment.
Node 20 already has undici for its native fetch, but I think this is a good idea to maintain compatibility with other Node versions.
alhansrisuk
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since node 16 node's built-in
fetch()global does not use the HTTP stack provided by the traditional built-inhttp/httpsmodules. We relied on those modules to handle local self-sign SSL certificate requests against clay sites.Problem: import commands using any version of node higher or equal to 16 against a local clay instance fail.
e.g.: export | import using node 20
after this fix:
