improves logging for explicitly handled errors #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd notImplemented error
Amphora provides a mechanism to supply an error status code and message
in a response. This is accomplished by setting the following properties
on an **Error**:
```js
const err = new Error('Invalid Request');
err.status = 400;
err.message = 'Invalid Request';
throw err;
```
Errors thrown in a model's `render` or `save` will make their way to
the main error handler defined in `lib/responses.js`.
Prior to this commit, those errors were not logged, leaving the logging
up to the implementer.
|
@Tiffachow PR I incorporated your commits from #693 and combined them with some additional logging changes that were requested here. Since #693 was opened from an older fork there were conflicts with earlier changes that added |
jpope19
reviewed
Feb 23, 2021
jpope19
reviewed
Feb 23, 2021
jpope19
reviewed
Feb 23, 2021
Tiffachow
approved these changes
Feb 23, 2021
This commit is unrelated to the primary purpose of this branch, but the unused variable is causing the linter to fail.
james-owen
approved these changes
Feb 23, 2021
jpope19
approved these changes
Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request incorporates elements of #693 with a few additional changes:
origin/masterto handle merge conflicts for existing logging updates.composer.jswhen an error has a.status(leaving the logging up to the error handler inresponses.js)..statusproperty at thewarn(4xx) orerror(5xx) level.Change (1) pulls in a previous commit that added URLs to response logs.
Change (2/3) will allow dynamic routes to return 404s/400s without logging at the
errorlevel.