changes log level for 404s from ERROR to INFO #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a page does not exist (ie. 404) Amphora was producing an ERROR-level (50) message. This devalued the meaning of the ERROR level by polluting logs with errors for things like requests to '/favicon' that browsers automatically make. A 404 is not an error, it's expected behavior. I think INFO is a suitable level for 404s because they are mostly noise; no additional value is provided to what one can glean from making a client-side request.
Pull Request Test Coverage Report for Build 2412
💛 - Coveralls |
james-owen
approved these changes
Sep 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a page does not exist (ie. 404) Amphora was producing an ERROR-level (50) message. This devalued the meaning of the ERROR level by polluting logs with errors for things like requests to '/favicon' that browsers automatically make.
A 404 is not an error, it's expected behavior.
I think INFO is a suitable level for 404s because they are mostly noise; no additional value is provided to what one can glean from making a client-side request.