-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subsite support #674
Subsite support #674
Conversation
Pull Request Test Coverage Report for Build 2392
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🏄
_.mergeWith(controller, subsiteController, (par, sub) => { | ||
if (Array.isArray(par) && Array.isArray(sub)) { | ||
return par.concat(sub); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs to return par
if sub is not an array for whatever reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be ok as is, tested with String params during dev
https://lodash.com/docs/4.17.15#mergeWith
If customizer returns undefined, merging is handled by the method instead. The customizer is invoked with six arguments:
(objValue, srcValue, key, object, source, stack).
Note: This method mutates object.
dependencies:
adds subsite support. allows for the following file structure inside of sites:
required config for subsites: