Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifies put methods to send siteSlug to DB #665

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

manuelurenah
Copy link
Contributor

@manuelurenah manuelurenah commented Jun 5, 2019

Description

QA

In order to be able to test this feature, you should link this package and clay/amphora-storage-postgres#45 in a clay project. I've been using https://github.com/clay/clay-starter to develop this feature, that's a good starting point.

Testing steps

  1. Go inside a clay project directory (i.e.: clay-starter)
  2. Spin up an instance of clay with make
  3. Open another terminal window or tab and make sure adminer is up and running using docker-compose up -d adminer
  4. Make your way into the app directory (or where the package.json file is located) and link the previously mentioned packages with npm link amphora && npm link amphora-storage-postgres (make sure the packages are in the correct branch and linked)
  5. Restart the clay instance with rs. After it's done, you should a message stating Migrations Complete
  6. Go into http://localhost:8080 an login the db (system, server, username and database are all postgres; password is example)
  7. Check that the schemas of all public tables have the following columns: created_at, which should default to the date the row was created; updated_at, which should default to the date the row was created and update itself if the data changes; and site_id, which should contain the site slug
  8. Bootstrap the starter data with make bootstrap (where the Makefile is located)
  9. You should be able to see in all the public tables new entries with all the previous columns plus the new ones.
  10. You should be able to update, publish, archive and everything else without ay problems

@manuelurenah manuelurenah changed the title Site id column Modifies put methods to send siteSlug to DB Jun 5, 2019
@coveralls
Copy link

coveralls commented Jun 5, 2019

Pull Request Test Coverage Report for Build 2343

  • 40 of 40 (100.0%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2339: 0.0%
Covered Lines: 4046
Relevant Lines: 4046

💛 - Coveralls

Copy link
Member

@jjpaulino jjpaulino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants