-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modifies put methods to send siteSlug to DB #665
Open
manuelurenah
wants to merge
9
commits into
master
Choose a base branch
from
site-id-column
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+98
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuelurenah
changed the title
Site id column
Modifies put methods to send siteSlug to DB
Jun 5, 2019
Pull Request Test Coverage Report for Build 2343
💛 - Coveralls |
fxisco
approved these changes
Jun 19, 2019
jjpaulino
approved these changes
Jun 24, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
publish
,create
andputLatest
methods fromservices/pages
to be able to send thesiteSlug
to the db.put
, methods fromservices/uris
to be able to send thesiteSlug
to the db.putRouteFromDB
, methods fromservices/response
to be able to send thesiteSlug
to the db.QA
In order to be able to test this feature, you should link this package and clay/amphora-storage-postgres#45 in a clay project. I've been using https://github.com/clay/clay-starter to develop this feature, that's a good starting point.
Testing steps
clay-starter
)make
adminer
is up and running usingdocker-compose up -d adminer
app
directory (or where thepackage.json
file is located) and link the previously mentioned packages withnpm link amphora && npm link amphora-storage-postgres
(make sure the packages are in the correct branch and linked)rs
. After it's done, you should a message statingMigrations Complete
postgres
; password isexample
)created_at
, which should default to the date the row was created;updated_at
, which should default to the date the row was created and update itself if the data changes; andsite_id
, which should contain the site slugmake bootstrap
(where theMakefile
is located)