Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prefer url #636

Merged
merged 1 commit into from
Mar 7, 2019
Merged

prefer url #636

merged 1 commit into from
Mar 7, 2019

Conversation

jonwinton
Copy link
Contributor

@jonwinton jonwinton commented Mar 7, 2019 •
edited
Loading

When moving to Amphora v7 we began the deprecation customUrl in favor of url but the internal preference of the publish rule never changed. This is a bug we need to resolve to deprecate that property.

yuliyv
yuliyv approved these changes Mar 7, 2019
View reviewed changes
Copy link

@yuliyv yuliyv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👒

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2099

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 2090: 0.0%
Covered Lines: 4431
Relevant Lines: 4431
💛 - Coveralls

@jonwinton jonwinton merged commit 491cd57 into master Mar 7, 2019
@jonwinton jonwinton deleted the customUrl-preference branch March 7, 2019 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manuelurenah manuelurenah manuelurenah approved these changes

@yuliyv yuliyv yuliyv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jonwinton @coveralls @yuliyv @manuelurenah