New DB API: Storage #554
Merged
New DB API: Storage #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nelsonpecora
approved these changes
Jun 21, 2018
| })).then(JSON.parse).then(convertDBListToReferenceObjects); | ||
| })); | ||
|
|
||
| return promise.then(JSON.parse).then(convertDBListToReferenceObjects); |
There was a problem hiding this comment.
does pipeToPromise still return strings of JSON?
There was a problem hiding this comment.
Unfortunately yes because the stream requires strings to operate, so we have to parse it out. I've done a little refactor on this and will push it up soon. The only thing using method is scheduling, so when that gets pulled out this is just going to move over
|
|
||
| Eventify.enable(module.exports); | ||
|
|
||
| _.each(['put', 'batch', 'del'], exposeMethodToOutsideListeners); |
There was a problem hiding this comment.
what outside listeners did we have (if any)?
There was a problem hiding this comment.
None, we just never deprecated it 😬
jonwinton
added a commit
that referenced
this pull request
Sep 20, 2018
* stashing small update * stashing changes; * stashing changes before beginning testing refactor * testing for non-api tests * fixing api tests * updating db tests * 100% * eslint * moving packages over to dev dependencies * more updates * lots of changes * metadata for the layouts * forgot file * more layouts/meta work * getting things in order * New DB API: Storage (#554) * stashing small update * stashing changes; * stashing changes before beginning testing refactor * testing for non-api tests * fixing api tests * updating db tests * 100% * eslint * moving packages over to dev dependencies * Meta Patch Requests (#569) * adding patch support * code comments * Publish data meta (#571) * adding patch support * code comments * bringing in meta updating * cleanup * cleaning up some publish/unpublish logic and keeping page history * passing bus publish method to plugins * using meta object and raw query for db * small pruning and comments * using amphora-fs for file service * updating for amphora-search * lists api * removing cache control * moving plugins * some testing work * components & composer services * stashing tests * more tests * middle of tests * stashing test changes * initial fixes done, moving to api tests * most testing work done * mostly done * fixing model call * making a doc of changing things * linting and test changes * writing plugin docs * writing more docs * adding to table of contents * pass site to attachRoutes * do not need that package * fixing issue * newline * no actual changes * Validate site routes (#598) * no actual changes * attach amphora api routes to the router first to avoid misleading errors caused by less specific site-level routes * set reservedRoutes in a function + pr feedback * making long stacktraces an env var * stashing changes * fixing up some tests * actually fixing tests * V7 meta changes (#605) * no actual changes * some fixes discovered when working with kiln * unwrap list routes in amphora-storage-postgres * normalizing fields between page and layout metadata and removing unused fields * use iso string timestamps * 7.0.0-0 * Redirect From Published Meta (#607) * adding in redirect and fixing eslint comment * moving to responses * name change * look for custom url and dynamic prop before site pub chain * removing comment * package-lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storageIssue: #553