V5 #505
Merged
V5 #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* moving response termination to renderer * linting * addressing feedback
* moving response termination to renderer * linting * initial work * addressing comments
* moving response termination to renderer * linting * addressing feedback * control service stops checking for memory leak * lint fixes
Pull Request Test Coverage Report for Build #15
💛 - Coveralls |
lib/render.test.js
Outdated
| // 3. get the template that will be composed | ||
| components.getTemplate.returns('asdf'); | ||
| // // 3. get the template that will be composed | ||
| // components.getTemplate.returns('asdf'); |
There was a problem hiding this comment.
should this (and other commented out lines from this PR) be removed from the test file? Hard to tell if a commented out part of a test is temporarily broken or purposeful removal
There was a problem hiding this comment.
Oh, good find. Forgot that was there.
lib/services/publish.test.js
Outdated
| @@ -7,11 +7,10 @@ const _ = require('lodash'), | |||
| db = require('../services/db'), | |||
| lib = require(`./${filename}`); | |||
|
|
|||
| require('sinon-as-promised'); | |||
| // require('sinon-as-promised'); | |||
There was a problem hiding this comment.
Yep! Will also remove. So much deprecation. This is a reminder to myself to also check that I removed winston
byronhulcher
approved these changes
Feb 12, 2018
nelsonpecora
approved these changes
Feb 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Changes
resolveMediacontrolOther Changes
winstonlogger completely from tests