Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock redis instance when doing a specific task #42

Open
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

pedro-rosario
Copy link

@pedro-rosario pedro-rosario commented May 28, 2019

Related clay/amphora#606

TODO:

  • Feature description
  • Documentation
  • Tests

@pedro-rosario pedro-rosario changed the title [WIP] Lock redis instance when doing a specific task Lock redis instance when doing a specific task May 29, 2019
redis/lock.js Outdated Show resolved Hide resolved
redis/lock.js Show resolved Hide resolved
redis/lock.js Outdated Show resolved Hide resolved
redis/lock.js Outdated Show resolved Hide resolved
* prettier formatting

* jsdoc setup

* jsdoc started on all functions
Copy link
Contributor

@fxisco fxisco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some tests will add lot of value for the future, maybe not now but we could open an issue.

redis/lock.js Show resolved Hide resolved
redis/lock.js Outdated Show resolved Hide resolved
redis/lock.js Outdated Show resolved Hide resolved
@pedro-rosario
Copy link
Author

@fxisco Thank you for your feedback. No need to open an issue for the tests, in definitely adding them now!

redis/lock.js Outdated Show resolved Hide resolved
redis/lock.test.js Outdated Show resolved Hide resolved
redis/lock.test.js Outdated Show resolved Hide resolved
@pedro-rosario
Copy link
Author

Semaphore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants