Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplifies sitemaps implementation #72

Merged
merged 5 commits into from
Mar 13, 2018
Merged

Simplifies sitemaps implementation #72

merged 5 commits into from
Mar 13, 2018

Conversation

cperryk
Copy link
Contributor

@cperryk cperryk commented Mar 13, 2018 •
edited
Loading

  • Fixes issue in which sitemap entries were not streaming when there is a custom sitemap due to an malformed Elastic query sort property
  • Refactors sitemaps to drop handlebars templates. Now amphora-search pipes documents from custom sitemap indices directly to xmljs.js2xml. We should not be constraining the XML that can be generated or defining intermediary data structures without good reason.

Unrelated changes:

  • Fixes an issue in pagelist in which tests sometimes fail because sometimes firstPublishTime is a millisecond off from publishTime because they both invoke a new Date independently

@cperryk cperryk changed the title Expect sitemap entry loc property over url; fix sort on custom sitemap Expect correct custom sitemap entry props, fix sort on custom sitemap Mar 13, 2018
@coveralls
Copy link

coveralls commented Mar 13, 2018 •
edited
Loading

Coverage Status

Coverage decreased (-0.001%) to 99.862% when pulling 26b57dd on sitemaps-fixes into 297993c on master.

@cperryk cperryk changed the title Expect correct custom sitemap entry props, fix sort on custom sitemap Simplifies sitemaps implementation Mar 13, 2018
@cperryk cperryk merged commit 8753e72 into master Mar 13, 2018
@cperryk cperryk deleted the sitemaps-fixes branch March 13, 2018 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonwinton jonwinton jonwinton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cperryk @coveralls @jonwinton