Only include docs from the last two days in news sitemap #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reubenson
reviewed
Mar 9, 2018
lib/services/sitemaps/index.js
Outdated
| }, { | ||
| range: { | ||
| publication_date: { | ||
| gte : 'now-2d/d', |
There was a problem hiding this comment.
how strict is google on 'two days'? /d rounds down to the nearest day, so a query that's executed at 23:59 would grab articles from the past ~72 hours. should the query instead be for now-48h?
There was a problem hiding this comment.
My thought is that if Google meant "the last 48 hours" the guide would more precisely say "the last 48 hours." But it's ambiguous. I'll switch to the 48-hour window b/c that's what the Washington Post appears to be using for their news sitemaps.
reubenson
approved these changes
Mar 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The news sitemap should only include articles from the last two days as per Google's guide on news sitemap creation. This PR modifies amphora's search query to the news-sitemap-entries index so that it only gets articles from the last two days.