Don't swallow errors on bulk search #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
say what went wrong, as an aid to debugging
mheiber
force-pushed
the
patch-batch-search-error-swallowing
branch
from
8d61c28 to
8cf2122
Compare
jonwinton
previously approved these changes
Oct 6, 2017
jonwinton
suggested changes
Oct 6, 2017
lib/services/elastic.js
Outdated
| let str = ['Client.bulk errored on ' + util.inspect(ops, { | ||
| depth: 10 | ||
| })]; | ||
| const message = 'Client.bulk errored on:\n' |
There was a problem hiding this comment.
Can this be updated to use template literals?
|
@jonwinton cool, made the change 👍 |
jonwinton
approved these changes
Oct 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
say what went wrong, as an aid to debugging
Before:
After:
It took me about 20 minutes to figure out I was passing an invalid date, but if the error doesn't get swallowed then next time I can see "failed to parse [date]" which will help with this sort of problem.