Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't call bluebird.defer #116

Merged
merged 2 commits into from
Aug 17, 2022
Merged

fix: don't call bluebird.defer #116

merged 2 commits into from
Aug 17, 2022

Conversation

james-owen
Copy link
Member

Bluebird's defer method is deprecated. Switching to the strategy here http://bluebirdjs.com/docs/api/deferred-migration.html

@james-owen james-owen marked this pull request as ready for review August 16, 2022 16:08
@james-owen james-owen requested a review from jjpaulino August 16, 2022 16:12
@amirandalibi amirandalibi merged commit d422dd5 into master Aug 17, 2022
@amirandalibi amirandalibi deleted the jowen/defer branch August 17, 2022 15:12
@laddhoffman-swarm
Copy link

laddhoffman-swarm commented Aug 22, 2022

This does not seem to work. From MDN

The arguments object is a local variable available within all non-arrow functions.

Here you're using an arrow function, and I get ReferenceError: arguments is not defined.

@laddhoffman-swarm
Copy link

Here's a suggested fix,

...
const promise = new Promise((_resolve, _reject) => {
  resolve = _resolve;
  reject = _reject;
  });
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants