Include in response only CSS variations that are needed #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amycheng
reviewed
May 24, 2018
| .reduce((prev, name) => { | ||
| prev.push( | ||
| path.join(assetDir, 'js', `${name}.js`), | ||
| path.join(assetDir, 'js', `${name}.${slug}.js`), |
There was a problem hiding this comment.
don't think we have site-specific component js?
There was a problem hiding this comment.
This looks like it was pulled from the previous version that also got three js files for each component https://github.com/clay/amphora-html/blob/v3.3.0/lib/media.js#L192
I can't necessarily speak to why it was setup that way originally, but I suspect it was included here for compatibility reasons
| const siteSlug = site && site.slug; | ||
|
|
||
| cssFilePaths = state._components | ||
| .reduce((acc, curr) => { |
There was a problem hiding this comment.
what is the var acc referring to?
There was a problem hiding this comment.
Pretty sure it's the local var for the accumulation of the reduction, could probably change this to pathsToRetrieve or something if that's more clear
zonika
approved these changes
May 25, 2018
jonwinton
approved these changes
May 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures CSS variations that do not appear on the requested page do not appear in the response HTML.