update CSS byte validation to 75000 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-owen
approved these changes
Sep 26, 2022
lib/media.js
Outdated
| @@ -71,8 +71,8 @@ function combineFileContents(fileArray, directory, filePrefix) { | |||
| .then(function (fileContents) { | |||
| const joined = fileContents.join(''); | |||
|
|
|||
| if (util.getByteLength(joined) > 50000) { | |||
| log('warn', 'Combined CSS contents are beyond the 50000 byte limit specified by AMPHTML.'); | |||
| if (util.getByteLength(joined) > 75000) { | |||
There was a problem hiding this comment.
Might be good to link to the relevant docs to show where this number comes from.
alex-brand-voxmedia
approved these changes
Sep 26, 2022
| if (util.getByteLength(joined) > 50000) { | ||
| log('warn', 'Combined CSS contents are beyond the 50000 byte limit specified by AMPHTML.'); | ||
| if (util.getByteLength(joined) > 75000) { | ||
| log('warn', 'Combined CSS contents are beyond the 75000 byte limit specified by AMPHTML.'); | ||
| } |
There was a problem hiding this comment.
I wonder if you should put a second warning for articles > 70,000. So we can see how many articles are nearing the the limit too.
There was a problem hiding this comment.
great point, and I should take the opportunity to add a bit more context to the logged object too
alex-brand-voxmedia
approved these changes
Sep 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating our CSS validation to reflect the fact that the AMP byte limit was increased from 50000 to 75000 in 2020: ampproject/amphtml#26466
Jira: https://vmproduct.atlassian.net/browse/CB-57