Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

collect files fails when the source directory contains a space #84

Closed
gojko opened this issue Nov 9, 2016 · 0 comments
Closed

collect files fails when the source directory contains a space #84

gojko opened this issue Nov 9, 2016 · 0 comments
Labels
bug help wanted

Comments

@gojko
Copy link
Member

gojko commented Nov 9, 2016

package should be created even if the source directory has a space in the name. Currently, collect-files.js will fail when trying to pack the directory because the path is passed without the quotes.

the project path should get quotes in this line in collect-files.js. the test can be very similar to this one, with the addition of the source dir being renamed to something with a space.
@gojko gojko closed this as completed in a880734 Nov 11, 2016
gojko added a commit that referenced this issue Nov 11, 2016
@gojko
downgrade shelljs to avoid bug that would silently cause some files n…
bfcdef3 
…ot to be copied when using --local-dependencies

bugfix for deployment from directories containing a space (#84)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gojko