add ref to manager when disabled prop goes from true to false #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wmdmark
changed the title
true to false
|
Ah, good catch. Thanks for submitting this! Looks good, though I believe you missed the case for when the prop goes from |
|
@clauderic oops, did not think to handle that since it was the other way that was broken for me. Does this look OK for handling both cases? Have not had a chance to test yet. |
|
@clauderic any thoughts on this? would be nice to get this merged so I can stop using my fork. |
|
I just merged #34, going to close this out. Thank you for submitting this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue for when a
SortableElementgoes from a disabled to a non-disabled state.