Fix #38: Browser's autocomplete stops the up and down keys from working #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing the hours and minutes using the up and down keys does not work reliably if the browser's autocomplete functionality is enabled. The autocomplete functionality is not needed anyway in the hours/minutes inputs. Solution: Add attribute autocomplete="off" to hours/minutes inputs. To replicate: - Enter some number(s) into the hours or minutes inputs - Confirm the number(s) (e.g. by chaging the focus) - Try to change the value using keyboard up and down keys - When you reach any of the previously entered values, the browser opens an autocompletion menu and the keyboard arrows no longer work as expected Tested on Chrome 68.0.3440.84 (Windows).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing the hours and minutes using the up and down keys does not work reliably if the browser's autocomplete functionality is enabled.
The autocomplete functionality is not needed anyway in the hours/minutes inputs.
Solution: Add attribute autocomplete="off" to hours/minutes inputs.
To replicate:
Tested on Chrome 68.0.3440.84 (Windows).