Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the input-type of the hoursminutes-input to number #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Anubiso
Copy link

@Anubiso Anubiso commented Aug 25, 2017

In the mobile context the opened virrtual keyboard is defined by the input type.
For this reason and because hours and minutes can only be numbers this should be a number-input.

In the mobile context the opened virrtual keyboard is defined by the input type. 
For this reason and because hours and minutes can only be numbers this should be a number-input.
@Anubiso
Copy link
Author

Anubiso commented Aug 30, 2017

"09" for example is also valid in a number-type input

@Andreasbaaserud
Copy link
Contributor

Currently it acts fine as a text type input field. It validates fine and you can select hour and minute from the md-clock directive.

Why do you want a number type input field?

@Anubiso
Copy link
Author

Anubiso commented Aug 30, 2017

When you are using text type input field on mobile devices (android or apple or windows)
the virtual keyboard will open with the alpha chars, if the user disabled the number row (which is possible atleast on android) he has to tap the 123 button everytime just to get to the number input.

Text-Input:
screenshot_20170830-185741

Number-Input:
screenshot_20170830-185817

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants