Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add MinCommissionRate param #3

Merged
merged 7 commits into from
May 31, 2023
Merged

Conversation

alchemist-ti
Copy link

@alchemist-ti alchemist-ti commented May 25, 2023

Description

Resolves: classic-terra/core#109, Add MinCommissionRate param to x/staking module. Cherry-pick from cosmos#10529, cosmos#12028.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@alchemist-ti alchemist-ti marked this pull request as ready for review May 29, 2023 10:39
@alchemist-ti alchemist-ti force-pushed the min-commission-rate branch from e961aff to 0c3e2d1 Compare May 29, 2023 11:03
Copy link

@nghuyenthevinh2000 nghuyenthevinh2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alchemist-ti can you clean up this pr again then merge. LGTM!

Please create a new release for this also, then update go.mod on core to use new sdk

@alchemist-ti
Copy link
Author

alchemist-ti commented May 31, 2023

@alchemist-ti can you clean up this pr again then merge. LGTM!

Please create a new release for this also, then update go.mod on core to use new sdk

@nghuyenthevinh2000 Ok, v0.45.14?

@alchemist-ti alchemist-ti force-pushed the min-commission-rate branch from ac5434c to ad2136e Compare May 31, 2023 08:21
@alchemist-ti alchemist-ti merged commit 39362c4 into rebels May 31, 2023
@alchemist-ti alchemist-ti deleted the min-commission-rate branch May 31, 2023 08:22
@nghuyenthevinh2000
Copy link

Something with -terra name

@alchemist-ti
Copy link
Author

Something with -terra name

Following the previous rules, I released v0.45.14-classic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Validator Min. Commission 5%
2 participants