Mark instances NOINLINE #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes GHC issue 23109
christiaanb
added a commit
to clash-lang/clash-compiler
that referenced
this pull request
Aug 28, 2023
Without it, Clash goes into an infinite loop on T1354A in combination with: clash-lang/ghc-typelits-knownnat#47
christiaanb
added a commit
to clash-lang/clash-compiler
that referenced
this pull request
Oct 25, 2023
Without it, Clash goes into an infinite loop on T1354A in combination with: clash-lang/ghc-typelits-knownnat#47
I'm assuming it's more a "works around issue 23109"? |
christiaanb
added a commit
to clash-lang/clash-compiler
that referenced
this pull request
Nov 3, 2023
Without it, Clash goes into an infinite loop on T1354A in combination with: clash-lang/ghc-typelits-knownnat#47
|
Yes, that's correct, in a way. The thing is, the plugin is doing something that is very likely impossible to do as a regular programmer. |
|
Gotcha, never mind my comment then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GHC issue 23109