Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elide unsafeCoerce from promoted nats and select #2843

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Elide unsafeCoerce from promoted nats and select #2843

wants to merge 2 commits into from

Conversation

kleinreact
Copy link
Member

@kleinreact kleinreact commented Nov 15, 2024 •
edited
Loading

The PR elides the need of unsafeCoerce in Clash.Promoted.Nat via using the tools provided by base (>= 4.16.0.0, GHC >= 9.2) instead. Furthermore, it elides the need for unsafeCoerce in Clash.Sized.Vector.

Still TODO:

  • Add a working fallback implementation for the old versions of GHC
  • Check copyright notices are up to date in edited files
  • Write a changelog entry (see changelog/README.md)

@kleinreact kleinreact marked this pull request as draft November 15, 2024 12:11
@kleinreact kleinreact force-pushed the less-unsafecoerce-for-promoted-nats branch 6 times, most recently from 45b561f to 554f2da Compare November 15, 2024 20:35
@kleinreact kleinreact changed the title Use less unsafeCoerce to define the promoted nats Use less unsafeCoerce to define promoted nats and select Nov 15, 2024
@kleinreact kleinreact marked this pull request as ready for review November 16, 2024 11:15
@kleinreact kleinreact force-pushed the less-unsafecoerce-for-promoted-nats branch from be0c2f7 to 3a0caeb Compare November 20, 2024 20:25
@kleinreact kleinreact changed the title Use less unsafeCoerce to define promoted nats and select Elide unsafeCoerce from promoted nats and select Nov 20, 2024
@kleinreact kleinreact force-pushed the less-unsafecoerce-for-promoted-nats branch 2 times, most recently from 7d470c9 to de50812 Compare November 21, 2024 04:23
@kleinreact kleinreact force-pushed the less-unsafecoerce-for-promoted-nats branch from de50812 to 3c1953f Compare November 21, 2024 16:58
@kleinreact kleinreact mentioned this pull request Jan 13, 2025
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowanG077 rowanG077 rowanG077 left review comments

@DigitalBrains1 DigitalBrains1 DigitalBrains1 left review comments

Assignees
No one assigned
Labels
needs-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kleinreact @DigitalBrains1 @rowanG077